Discussion:
All current JsInterop-Annotations jar files are missing manifest content.
Rasmus Olesen
2018-07-20 11:49:44 UTC
Permalink
Hi

Is there a specific reason for the jsinterop-annotations jar files not
containing any manifest files/info/content ?
https://mvnrepository.com/artifact/com.google.jsinterop/jsinterop-annotations

It might not be needed for the included annotations, but we really need it
for handling jar files during build and deployment.
And isn't it bad practice to release jar files without a manifest?

Best Regards
/Rasmus
--
You received this message because you are subscribed to the Google Groups "GWT Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+***@googlegroups.com.
To post to this group, send email to google-web-***@googlegroups.com.
Visit this group at https://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/d/optout.
Thomas Broyer
2018-07-20 13:05:32 UTC
Permalink
Post by Rasmus Olesen
Hi
Is there a specific reason for the jsinterop-annotations jar files not
containing any manifest files/info/content ?
https://mvnrepository.com/artifact/com.google.jsinterop/jsinterop-annotations
This is just a side-effect of how they're
produced: https://gwt.googlesource.com/gwt/+/2.8.2/maven/lib-gwt.sh#93
Post by Rasmus Olesen
It might not be needed for the included annotations, but we really need it
for handling jar files during build and deployment.
And isn't it bad practice to release jar files without a manifest?
Bad practice? No idea. Not that I know.
In all honesty, I've never ever used JAR manifests, except in a few cases
with a Main-Class.

Feel free (and invited!) to contribute a patch to the scripts to ensure a
manifest is present in all JARs.
--
You received this message because you are subscribed to the Google Groups "GWT Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+***@googlegroups.com.
To post to this group, send email to google-web-***@googlegroups.com.
Visit this group at https://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/d/optout.
Loading...